search

guard / guard-cucumber

Guard::Cucumber automatically run your features (much like autotest)
https://rubygems.org/gems/guard-cucumber
MIT License
86 stars 36 forks source link

Guard::Notifier should not be used within child process (formatter) #19

Open e2 opened 9 years ago

e2 commented 9 years ago

Guard::Cucumber uses Guard::Notify from within the Formatter.

While this works (because of how Guard::Notifier passes available notifiers through environment variables - tied to the PID of the parent process, and other horrors), it shouldn't be necessary - notifications should happen after reading the results file within the Runner.

astery commented 9 years ago

Does it related to this error?

e2 commented 9 years ago

@astery - no, that looks like a new bug.

I'd need to know what options are passed to notify. Could you add the following line:

$stderr.puts [msg, options].inspect

As the first line in the self.notify() method here (line 112):

/home/user/.gem/ruby/2.0.0/gems/guard-compat-1.2.1/lib/guard/compat/plugin.rb

Or, if you can create a repo reproducing the problem, I could quickly find the cause and fix it.

astery commented 9 years ago

@e2, thank you for response. I created separated issue