Closed hron closed 8 years ago
Really cool patch and cleanup, thanks! I like how you're using Guard::RSpec as a reference. (Both these plugins have a lot in common).
Also, recent parallel_tests has a --
option, which kind of helps manage RSpec and Parallel test options:
https://github.com/grosser/parallel_tests#setup-for-non-rails
I'll release this as 2.0.0 . I don't think a deprecation version is needed, since migrating should be trivial.
Released as v2.0.0.
Thanks again!
Migration may be trivial, but it should still be documented. Any plans to update the changelog for 2.0? I could try contributing something, but I’d have to read the code change to work out what the correct approach for migrating might be.
@sentience - yes, sorry, I've been using GitHub releases instead of the changelog, but I didn't link it.
@e2 Am I missing something? That release note doesn’t document the migration process either. As far as I can see, it just links to the code change, which is pretty tough to parse.
@sentience - yes, I guess the Readme could have a small migration section. The change is mostly cleanup and renaming options.
Personally, I'd just show an error when there are unrecognized options (some other plugins probably do that already).
The basic change is going from :cli
, :cmd_prefix
, :bundler
, :binstubs
and to just :cmd
and :cmd_additional_args
(less options, clearer, easier to setup more complex scenarios).
If you submit a PR for this, I'll gladly accept it.
Current scheme of command line args in guard-cucumber is very sophisticated. However it doesn't allow to use tools like parallel_tests.
This change standardize command line args with guard-rspec gem. The implemented change deprecates a lot of options, but it allows to use all of them by utilizing
:cmd
option.