search

guard / guard-cucumber

Guard::Cucumber automatically run your features (much like autotest)
https://rubygems.org/gems/guard-cucumber
MIT License
86 stars 36 forks source link

Feature: Cucumber 3.x Support #38

Closed todd-a-jacobs closed 4 years ago

todd-a-jacobs commented 5 years ago

This is a minimalist pull-request that:

  1. bumps the minimum Cucumber version to 3.1
  2. replicates the missing dump_count method from the cucumber-ruby source code
  3. passes all existing specs

This appears to close #36 and stops the NoMethodError exception raised from Guard::Cucumber::NotificationFormatter.

anicholson commented 5 years ago

This seems like the best minimal upgrade path to unblock folk without investigating what's needed to use #dump_count's replacement :)

jeffshantz commented 5 years ago

Thanks for this, @todd-a-jacobs.

piotr-kedziak commented 5 years ago

Hi, are this gem still maintained ?

marnen commented 5 years ago

Will this be merged at some point?

marnen commented 4 years ago

Can I help get this merged?

marnen commented 4 years ago

This still should be merged. Again, I'll ask: what's the delay? Can I help somehow?

rymai commented 4 years ago

@todd-a-jacobs Thank you, looks good to me! It looks like @e2 isn't maintaining the gem anymore so I'll merge and release a new version. :sunny: :rocket:

marnen commented 4 years ago

@rymai Thank you so much!