search

guard / guard-cucumber

Guard::Cucumber automatically run your features (much like autotest)
https://rubygems.org/gems/guard-cucumber
MIT License
86 stars 36 forks source link

Don't require Bundler to use binstubs #8

Closed JeanMertz closed 11 years ago

JeanMertz commented 11 years ago

Spring installs binstubs as bin/cucumber with this content:

#!/usr/bin/env bash
exec $(dirname $0)/spring cucumber "$@"

To execute this, I would need to start guard-cucumber with this command:

guard 'cucumber', binstubs: true, bundler: false

However, this was not possible before, because binstubs: true implied bundler: true. I'm sure there is a good reason for this, and feel free to reject this PR, this is just something that works for me, and I expect helps others as well.

netzpirat commented 11 years ago

That option check was done at the time where binstubs were only provided by Bundler, so I happily merge your pull request if you make the specs pass again :P Thanks a lot!

JeanMertz commented 11 years ago

@netzpirat I couldn't find this PR's build in Travis (not sure why?) and I am not behind my work machine right now, so I just changed it through the GitHub online editor.

As far as I could tell, the test description actually described something else than the test was doing. It should be green now.

edit: I guess the PR isn't building because Travis is pointing to your account, and not the Guard one.

netzpirat commented 11 years ago

@JeanMertz Thanks for the update! Release 1.4.0. Yes, the specs are from my early days and a bit awkward, wouldn't do it like that nowadays. Travis is indeed configured on the original repo and not this fork.

JeanMertz commented 11 years ago

:+1: