search

guard / guard-spork

Guard::Spork automatically manage Spork DRb servers
https://rubygems.org/gems/guard-spork
MIT License
296 stars 58 forks source link

Up to date gem dependencies version #122

Closed hbakhtiyor closed 9 years ago

hbakhtiyor commented 10 years ago

Compatible with spork-rails gem

xrkhill commented 10 years ago

The Travis build is failing because of dependencies that require Ruby 1.9.3. I'll need to investigate further before I can merge this change.

On Sun, Nov 10, 2013 at 10:12 AM, Abd ar-Rahman Hamidi < notifications@github.com> wrote:

Compatible with spork-rails gem

You can merge this Pull Request by running

git pull https://github.com/elasticad/guard-spork uptodate-gem-versions

Or view, comment on, or merge it at:

https://github.com/guard/guard-spork/pull/122 Commit Summary

  • Up to date gem dependencies version

File Changes

  • M guard-spork.gemspechttps://github.com/guard/guard-spork/pull/122/files#diff-0(12)

Patch Links:

JDHankle commented 10 years ago

+1 on this. Need Spork up to date for rails 4. See: https://github.com/sporkrb/spork/issues/223

xrkhill commented 10 years ago

I'll work on making a branch for the 1.5.x series for backward compatibility and then start making the changes for a 2.0 release with support for guard 2.0. Thanks for contributing.

kyletolle commented 9 years ago

Any updates on supporting guard 2.0? I get a huge deprecation message when running this gem with guard now.

xrkhill commented 9 years ago

@kyletolle Pull request #124 was merged today. You should no longer receive a deprecation message.

kyletolle commented 9 years ago

Thanks a ton @xrkhill for the update! It's very nice not having that deprecation warning when our specs run. Greatly appreciated.

e2 commented 9 years ago

I've added badges which include gemnasium.

As for updating - we don't want to restrict dependencies to newer gems unless something is broken - because sometimes if one gem locks to a previous version, locking to newer gems can prevent people from being able to install anything.

So unless Gemnasium is complaining (or there's a bug with an older version of something), we shouldn't be too quick to update - especially since users can upgrade to the latest gems as of now.

So I'm closing this.