search

guard / guard-spork

Guard::Spork automatically manage Spork DRb servers
https://rubygems.org/gems/guard-spork
MIT License
296 stars 58 forks source link

quiet option for spork (updated) #75

Closed mikesmullin closed 12 years ago

mikesmullin commented 12 years ago

based on latest guard-spork from today. resolved merge conflicts. see duplicate: https://github.com/guard/guard-spork/pull/58

thibaudgg commented 12 years ago

Thanks, I'll wait the merge of https://github.com/sporkrb/spork/pull/163

@timcharper it would be great if you can merge it soon. :)

mikesmullin commented 12 years ago

sweet looks like he did it

https://github.com/sporkrb/spork/commit/055b32fb771d6135728c25113851edb9d00cf561

thanks guys. now i won't need my forks.

thibaudgg commented 12 years ago

@mikesmullin can you also just add a little spec for that one please?

mikesmullin commented 12 years ago

@thibaudgg how is this?

thibaudgg commented 12 years ago

Nice, thanks for the specs. I'm wondering if we should not set this option to true by default, don't you think?

mikesmullin commented 12 years ago

well, the way i see it, you might want to see that stuff in the beginning when you're getting spork configured. but once its working, you probably never want to see it again. i'd probably just document the feature in the README.md so they know its an option once they start getting annoyed.

thibaudgg commented 12 years ago

You right, +1 for adding a note to the README and let it at false by default. Can you do that? It would be great. Thanks!

mikesmullin commented 12 years ago

ok how is that?

thibaudgg commented 12 years ago

Great, thanks!

webdesserts commented 12 years ago

I'm getting invalid option: -q (OptionParser::InvalidOption) after I try to use this options.

webdesserts commented 12 years ago

nvm, adding the git repository for the spork gem fixed it.

npearson72 commented 11 years ago

I'm also getting the error:

invalid option: -q (OptionParser::InvalidOption)

Tried adding the git repo to the gem file, but no luck for me. This is what I have:

gem 'guard-spork', '1.2.0', :git => 'git://github.com/guard/guard-spork.git'

Anyone else getting this problem?

bronson commented 11 years ago

@npearson72 it's because Spork's --quiet option hasn't been released yet (c'mon dudes, it's been five months)

gem 'spork', :git => 'https://github.com/sporkrb/spork.git' will fix it.

ghost commented 11 years ago

+1

jaymcgavren commented 11 years ago

+1 - did this feature fall through the cracks?

thibaudgg commented 11 years ago

Still not, I'm not sure that Spork is maintained anymore.