guard / guard-spork

Guard::Spork automatically manage Spork DRb servers
https://rubygems.org/gems/guard-spork
MIT License
296 stars 58 forks source link

Patch for Rinda::RingFinger.primary #91

Closed jarmo closed 11 years ago

jarmo commented 11 years ago

Patch for Rinda::RingFinger.primary hanging forever on Ruby 1.9.2 & 1.9.3 from http://www.ruby-forum.com/topic/4229908

Without this patch i'm seeing the symptoms of Rinda::RingFinger.primary blocking forever.

jarmo commented 11 years ago

Unfortunately this patch has to be at Spork side too to have full effect :( It seems to me though that Spork maintainer is not active at this moment.

All of this patch and other Rinda::RingFinger specific code can be removed when https://github.com/sporkrb/spork/pull/217 and https://github.com/sporkrb/spork/pull/214 have been merged. But as i said, Spork maintainer seems to be inactive.

thibaudgg commented 11 years ago

Ok, as long as it works as well for other users, I see no problem to keep it that way in the guard-spork side. @nixme and @timcharper can you merge theses PR please?