Closed vaz closed 8 years ago
I can merge and release this after the minor changes above.
Everything else looks good to me.
Surprisingly lots of work was needed for this.
It's awesome work!
For readability it might be better to implicitly return false instead of relying on Kernel.warn
to return nil
. But I don't mind personally since that's covered by tests.
Just squash the changes (so the history isn't as intimidating for future contributors) and I'll merge and release immediately.
Thanks! Agreed on the explicit false
return value, it is more readable. Added that and squashed.
If OS X >= 10.9 (Darwin >= 13.0): all is well.
Else if OS X >= 10.6 (Darwin >= 10.0): if
rb-fsevent
> 0.9.4, fall back to polling and show warning recommending to userb-fsevent=0.9.4
(Darwin < 10 not supported.)
See this gist for test: https://gist.github.com/vaz/fd6ee4c3563425ec11c24b96cc9da13b