search

guard / listen

The Listen gem listens to file modifications and notifies you about the changes.
https://rubygems.org/gems/listen
MIT License
1.92k stars 247 forks source link

Issues with Ruby version >=2.2.3, <2.2.5 for listen v3.1.5 #414

Closed paulgoetze closed 4 years ago

paulgoetze commented 8 years ago

The latest ruby_dep release (v1.4.0) requires Ruby version >=2.2.5. Version 3.1.5 of listen depends on ruby_dep ~> 1.2 which can also be resolved to ruby_dep v1.4.

This leads to issues when resolving the dependencies for listen when using Ruby version >=2.2.3 and <2.2.5.

Resolving dependencies...
ruby_dep-1.4.0 requires ruby version >= 2.2.5, which is incompatible with the
current version, ruby 2.2.3p173

Should listen require min Ruby version >= 2.2.5 as well or just depend on ruby_dep ~> 1.4?

e2 commented 8 years ago

Thanks for letting me know.

Yes, if you don't care about Ruby < 2.2.5, you can just lock ruby_dep to '~> 1.4'.

Using SemVer here to solve this is the right thing to do.

I'll likely have updates for ruby_dep and listen soon though.

It's a tricky situation. Overall, people should be using either: listen 3.1 + ruby_dep 1.4 or listen 3.0 + ruby_dep 1.3.

I'll have to update the README for Listen to mention this.

ColinDKelley commented 4 years ago

Ok to close this issue?