search

guard / listen

The Listen gem listens to file modifications and notifies you about the changes.
https://rubygems.org/gems/listen
MIT License
1.92k stars 246 forks source link

Travis: jruby-9.2.0.0 #435

Closed olleolleolle closed 6 years ago

olleolleolle commented 7 years ago

This PR updates the CI matrix to use latest JRuby.

Blog post: JRuby 9.2.0.0 released

olleolleolle commented 6 years ago

The build fails.

Ah, the issue is that ruby_dep does not support newer versions of Ruby.

In order to work around that, I began work on a PR there: https://github.com/e2/ruby_dep/pull/35

junaruga commented 6 years ago

Now the latest JRuby version becomes 9.2.0.0. http://jruby.org/

olleolleolle commented 6 years ago

Thanks, @junaruga, I updated the PR to reflect that.

junaruga commented 6 years ago

@olleolleolle sorry this PR has error.

RubyDep Error: Unrecognized JRuby version: "9.2.0.0"

We might have to check a logic of ruby-dep, or "9.2.0.0" still does not exist in Travis? https://rubygems.org/gems/ruby_dep/

Did you rebase to latest master branch? This repo's tests are failed for only JRuby. See https://travis-ci.org/guard/listen/builds/387076637

olleolleolle commented 6 years ago

@junaruga The ruby_dep project, which listen is using in its build, seems to have slowed down.

The logic in ruby_dep needs amending, to know about what MRI version "jruby-9.2.0.0" is equivalent to.

In order to support earlier JRuby versions, I offered a ruby_dep PR. No answer on that.

(I'll make a rebase this PR onto master. Update: Done.)

rymai commented 6 years ago

@olleolleolle @junaruga Thanks! Superseded by https://github.com/guard/listen/pull/446.