⚠ assigned but unused variable - from_change, to_change

guard / listen

The Listen gem listens to file modifications and notifies you about the changes.

https://rubygems.org/gems/listen

MIT License

1.92k stars 246 forks source link

⚠ assigned but unused variable - from_change, to_change #438

Closed amatsuda closed 6 years ago

amatsuda commented 6 years ago

Current 3.1.5 gem prints "assigned but unused variable" warnings with Ruby 2.5.

% ruby -vrlisten -e ''
ruby 2.5.0dev (2017-10-20 trunk 60219) [x86_64-darwin15]
.../ruby/gems/2.5.0/gems/listen-3.1.5/lib/listen/queue_optimizer.rb:110: warning: assigned but unused variable - from_change
.../ruby/gems/2.5.0/gems/listen-3.1.5/lib/listen/queue_optimizer.rb:111: warning: assigned but unused variable - to_change

Here's a fix.

coveralls commented 6 years ago

Coverage decreased (-0.1%) to 97.668% when pulling 1c7f905a8e64abe452378e28318082383f81b421 on amatsuda:warnings into 46a6adb29153253c4c2043f7e31dd7d091e17361 on guard:master.

rymai commented 6 years ago

@amatsuda Thank you, looks good to me! :heart: :yellow_heart: :green_heart: :rocket: