Upgrade to latest rb-fsevent and rb-notify releases

guard / listen

The Listen gem listens to file modifications and notifies you about the changes.

https://rubygems.org/gems/listen

MIT License

1.92k stars 246 forks source link

Upgrade to latest rb-fsevent and rb-notify releases #443

Closed thibaudgg closed 6 years ago

thibaudgg commented 6 years ago

Latest rb-fsevent release is fixing an annoying issue, I think it would worth forcing the upgrade here.

coveralls commented 6 years ago

Coverage decreased (-0.09%) to 97.676% when pulling 2875fb000a79a0f5a4be1f19108173b51a8c87db on rb-fsevent-upgrade into 46a6adb29153253c4c2043f7e31dd7d091e17361 on master.

rymai commented 6 years ago

CI doesn't seem to like the change, though... :/

thibaudgg commented 6 years ago

Yeah, Travis config seems to be broken here (see https://github.com/guard/listen/pull/442), @e2 could you please have a look, maybe ruby_dep needs an update?

junaruga commented 6 years ago

@e2 I think at least this PR improves current situation.

Current master https://travis-ci.org/guard/listen/builds/248699966

It is better to merge isn't it? Then we can change rbx-2 to rbx-3, and add Ruby 2.5 in other PRs, and check jruby issue etc.

rymai commented 6 years ago

@junaruga Sounds good!

junaruga commented 6 years ago

@rymai thanks for merging!