guard / listen

The Listen gem listens to file modifications and notifies you about the changes.
https://rubygems.org/gems/listen
MIT License
1.92k stars 245 forks source link

Allow Ruby 3 #490

Closed yahonda closed 3 years ago

yahonda commented 3 years ago

This commit addresses this conflict to support Ruby version 3.

% ruby -v
ruby 3.0.0dev (2020-08-31T09:51:59Z master 86737c509c) [x86_64-darwin20]
% bundle
Fetching gem metadata from https://rubygems.org/.........
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies...
Bundler found conflicting requirements for the Ruby version:
  In Gemfile:
    Ruby (= 3.0.0)

    listen was resolved to 3.2.1, which depends on
      Ruby (~> 2.2, >= 2.2.7)

Ruby (~> 2.2, >= 2.2.7), which is required by gem 'listen', is not available in the local ruby installation
%

Fix #489

Note

yahonda commented 3 years ago

Thanks for merging. It would be appreciated if the new version of listen is released to address this Rails CI error.

https://buildkite.com/rails/rails/builds/71484#3a7c0304-50fe-4e2b-98fd-c108d508d262/2365-2374

ioquatix commented 3 years ago

I will work on it. Should we merge https://github.com/guard/listen/pull/482 first?

yahonda commented 3 years ago

I think yes.

dentarg commented 3 years ago

@ioquatix Sorry to bother you. I'm just curious, did you manage to work out a release plan with Colin for #482? Or can this fix be released separately? Thanks for maintaining what feels like every important gem in the ecosystem! 😅