issue #487: unify Thread.new

guard / listen

The Listen gem listens to file modifications and notifies you about the changes.

https://rubygems.org/gems/listen

MIT License

1.92k stars 245 forks source link

issue #487: unify Thread.new #496

Closed ColinDKelley closed 3 years ago

ColinDKelley commented 3 years ago

Issue #487:

Unify thread creation through new Listen::Thread module.
Set the Thread#name = property to assist with debugging in the surrounding process.
rescue all exceptions in Listen::Thread and log them, including complete call stack (caller + exception backtrace) and show cause detail if any.
Only call one of Thread#join, Thread.kill.

ColinDKelley commented 3 years ago

@jonathanhefner Can you please also review?

ColinDKelley commented 3 years ago

I just rebased to master.

ColinDKelley commented 3 years ago

Thanks for the review, @ioquatix and @jonathanhefner. I believe all the comments are addressed, but don't hesitate to @-mention me if I missed anything, or more discussion would be helpful.

Rebasing + merging into master now.

ColinDKelley commented 3 years ago

Merged.