search

guard / listen

The Listen gem listens to file modifications and notifies you about the changes.
https://rubygems.org/gems/listen
MIT License
1.91k stars 245 forks source link

Disable fail-fast for CI matrix #555

Closed ybiquitous closed 1 year ago

ybiquitous commented 2 years ago

This change aims to prevent canceling running jobs if some jobs fail.

See also:

ColinDKelley commented 1 year ago

@ybiquitous I understand this disables "fail fast". But what is the problem if we leave "fail fast" enabled?

ybiquitous commented 1 year ago

@ColinDKelley Ah, sorry for the lack of why. I think it’s beneficial to disable fail-fast to make finding a problem with a specific OS or Ruby version easier.

But, since disabling fail-fast may increase CI time, it’s a trade-off. Feel free to close this PR if you’re against it. 😃

ColinDKelley commented 1 year ago

Ah, that does seem like a tradeoff. And the biggest reason to have Fail Fast enabled would be if you were waiting for build results as soon as possible. Which I never am here. So I'm good with this change!

ybiquitous commented 1 year ago

@ColinDKelley Thank you for the review and merge! 😊