search

guard / rb-inotify

A thorough inotify wrapper for Ruby using FFI.
MIT License
312 stars 64 forks source link

Use FFI::Library::LIBC in favor of magic "c" constant when calling ffi_lib. #20

Closed mbj closed 11 years ago

mbj commented 12 years ago

I suspect this change will work for other platforms very well.

Maher4Ever commented 12 years ago

I faced the same error on Rubinius: http://travis-ci.org/#!/guard/listen/jobs/2005566. This patch fixes it.

mbj commented 12 years ago

Yeah I had the same error when using the listen gem and tracked it down to rb-inotify :P

Maher4Ever commented 12 years ago

@mbj Great job fixing this! I was planning to send a pull request with a patch, but you were faster :) @nex3 Could you consider merging this patch and releasing a new version of rb-inotify?

mbj commented 12 years ago

@Maher4Ever Thx for the kudos. @nex3 Is there anything else open that forbids a release?

mbj commented 12 years ago

@Maher4Ever, contacted @nex3 via mail to push this issue to the head of his work-busy queue. Lets cross fingers he has the time to do a release shortly.

Maher4Ever commented 12 years ago

@mbj Awesome man! I can't wait to get this issue fixed :)

mbj commented 11 years ago

@Maher4Ever I also tried to contact @nex3 via twitter and did not got a reaction. Most likely he has something better to do. :(

mbj commented 11 years ago

@nex3 Some reaction is better than none!

mbj commented 11 years ago

@Maher4Ever Any idea to attract attention? I dislike moving around git sources in my Gemfile all the time. @nex3 You can add me to the gem on rubygems.org if you like, I can do the release for myself.

nex3 commented 11 years ago

Sorry everyone, I've been putting off dealing with my smaller project. I'll merge this now and cut a release.

mbj commented 11 years ago

@nex3 thx!

mbj commented 11 years ago

@nex3 Kindly reminding you on your promise to do a dot release containing this fix!

//cc @dkubb

EDIT: Spell nick dorrectly