Non-blocking check for stop in notifier and some semantic stuff accessing inotify.

rudolph9 commented 10 years ago

The pull makes three important changes:

Non-blocking check for the @stop flag.
- IO#select / Native#poll (depending on ruby_support_io?) are called in a loop with a 1 second timeout prior to making the blocking IO#readpartial / Native#read call. Upon timeout the @stop flag is checked. Should the flag be set the method returns nil otherwise the loop continues and another call to IO#select / Native#poll is made.
:name was added to the Native::Event struct and used accordingly in the Event class.
The size when reading the inotify file descriptor is now based on a call to Native#fpathconf which accesses the running systems NAME_MAX system variable rather than arbitrarily using 64 * Native::Event.size.

rudolph9 commented 9 years ago

@nex3 I'm curious you've had a chance to review my pull request.

ioquatix commented 7 years ago

Can you please rebase this on master and In will review.

ioquatix commented 7 years ago

I've reviewed this PR.

Unfortuantely

fix_encoding(@native[:name].to_ptr.read_string())

doesn't work as the ptr is 0 length.

Using fpathconf is a good idea and I've merged that.

Using poll is probably beyond the scope of this gem at this point in time, but an interesting idea.

guard / rb-inotify