Fix for breaking change for Ruby and runtime dependency version.

[junaruga]

This fixes https://github.com/guard/rb-inotify/issues/68 I guess that we can release 0.9.10. Because changing Ruby and run time dependency packages condition with maintenance version (Z of X.Y.Z) is not user friendly.

If you want to change those, the timing of major or minor version bump looks better.

Detail

• Fix for breaking change for dependency condition from 0.9.8 to 0.9.9. Keep Ruby and runtime dependency (ffi) to be same with rb-inotify 0.9.8.
• Fix skipped tests logic in Rakefile.
• Add Ruby 1.8, 1.9 test case on Travis.
• Add release test on Travis.

As you know, current bundle exec rake does not work. You can see the test result is not displayed. So, I fixed it.

$ bundle exec rake
/usr/local/ruby-2.4.1/bin/ruby -I/home/jaruga/git/rb-inotify/vendor/bundle/ruby/2.4.0/gems/rspec-core-3.4.4/lib:/home/jaruga/git/rb-inotify/vendor/bundle/ruby/2.4.0/gems/rspec-support-3.4.1/lib /home/jaruga/git/rb-inotify/vendor/bundle/ruby/2.4.0/gems/rspec-core-3.4.4/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb
..

Finished in 0.00142 seconds (files took 0.07249 seconds to load)
2 examples, 0 failures

[coveralls]

Changes Unknown when pulling d66a25290647dbf2f3229f3788ce621680a0c1d0 on junaruga:hotfix/breaking-dependencies-at-maintenance-version into on guard:master.

[junaruga]

First try: Ruby 1.8 and 1.9 tests were failed. https://travis-ci.org/guard/rb-inotify/builds/243822309

[coveralls]

Changes Unknown when pulling baa1e0cf0bcc7415b9e8318729b5ebf7f107d1ff on junaruga:hotfix/breaking-dependencies-at-maintenance-version into on guard:master.

[junaruga]

2nd Try: https://travis-ci.org/guard/rb-inotify/builds/243828896

An error occurred while installing tins (1.14.0), and Bundler cannot continue

[coveralls]

Changes Unknown when pulling bfb71630784e0baeef78a793f61f8cb362129bb5 on junaruga:hotfix/breaking-dependencies-at-maintenance-version into on guard:master.

[coveralls]

Changes Unknown when pulling 35b1df0c28d508002ba3596ab70b8e78cc5fb82e on junaruga:hotfix/breaking-dependencies-at-maintenance-version into on guard:master.

[coveralls]

Changes Unknown when pulling a1a52ca4e8e405a50781c731fd77e9eed1ac6bf5 on junaruga:hotfix/breaking-dependencies-at-maintenance-version into on guard:master.

[coveralls]

Changes Unknown when pulling e965e3dcaacf7dd90792d8d9a9a147d2c2a43378 on junaruga:hotfix/breaking-dependencies-at-maintenance-version into on guard:master.

[coveralls]

Changes Unknown when pulling 8f5fb7cd7b4d6693a5b43f5455f374d6ffd14893 on junaruga:hotfix/breaking-dependencies-at-maintenance-version into on guard:master.

[junaruga]

All the test cases passed.

[ioquatix]

Thanks for spending some time working on this.

The very first question to ask is, do we want to/need to support Ruby 1.8 and 1.9 in the first 1.0 release of rb-inotify.

Looking at what you've had to do, just to get it to work, in my mind, that makes me less likely to want to support it. I'm not adverse to it, I'm just trying to be realistic in terms of my time and what I'm able to maintain vs what I think is useful.

A specific thing I noticed was that you needed to add support for 0.x releases of FFI. While in theory, those releases are now stable - we don't know how buggy they are, and if they have security issues or not. It also means we are limited to features exposed by 0.5+ of FFI.

It looks like there are some other issues with the Gemfile which I missed, so we should fix those too - we can remove most of them, they are just for development/debugging.

Thoughts?

[ioquatix]

I am going to make a 0-x-stable branch and prepare a 0.9.10 release. Can you rebase your changes on that in about 5 minutes, and I'll retest and then release.

[ioquatix]

Okay, so the 0-x-stable branch is ready, it has this PR merged into it, and if you can update it with your recent changes, that would be great!

[junaruga]

I am going to make a 0-x-stable branch and prepare a 0.9.10 release. Can you rebase your changes on that in about 5 minutes, and I'll retest and then release.

Rebase? I guess you did it by myself.

if you can update it with your recent changes, that would be great!

You mean, you like me to send a PR for that to master branch, right? OK I can do it later.

[ioquatix]

So, I've merged this PR into 0-x-stable.

If there are further changes, can you rebase them on this branch, and then submit a PR for that branch 0-x-stable. Master will soon be updated with 1.0rc1

[junaruga]

@ioquatix OK I got it!