guardian / cdk

Generic Guardian flavoured AWS CDK components
https://guardian.github.io/cdk/
22 stars 5 forks source link

feat(experimental-ec2-pattern): Add `buildIdentifier` prop #2465

Closed akash1810 closed 1 month ago

akash1810 commented 1 month ago

What does this change?

A requirement of using GuEc2AppExperimental is the filename of the application artifact should include the build identifier. Adding a required buildIdentifier prop to GuEc2AppExperimental uses the type-system to enforce the requirement.

This change also adds a gu:build-identifier tag to the launch template, meaning launched instances receive this tag, improving observability. Furthermore, if instance logs are shipped with devx-logs then this tag becomes a marker on the log lines in Central ELK.

How to test

See updated snapshot.

How can we measure success?

Improved observability.

Have we considered potential risks?

N/A.

Checklist

[^1]: Consider whether this is something that will mean changes to projects that have already been migrated, or to the CDK CLI tool. If changes are required, consider adding a checklist here and/or linking to related PRs. [^2]: If you are adding a new construct or pattern, has new documentation been added? If you are amending defaults or changing behaviour, are the existing docs still valid?

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 5add16ca5febb242d3cdc877c1e208d9d67faeba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------- | ----- | | @guardian/cdk | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR