search

guardian / commercial-templates

Guardian bespoke GAM native styles
https://guardian.github.io/commercial-templates/
6 stars 3 forks source link

Hosted Native Traffic Driver #160

Open JonNorman opened 7 years ago

JonNorman commented 7 years ago

There are two different formats in DFP:

But we only have a single format in this repository, which appears to be a superset of all the fields in each format (there are some fields that are only needed for AMP or Web).

The format in DFP should be altered to reflect the test.json contents. Some of the fields that match between both formats in DFP are spelled slightly differently and so the templates themselves may need to be updated e.g. Brand Colour vs Brand Colour, Article Headline vs Title.

JonNorman commented 7 years ago

@RobertFreeman do you know whether this format (and associated styles) are even used? If not then it may be worth just deleting them.

RobertFreeman commented 7 years ago

It's up to you Jon - I'm not planning on optimising any Labs promotion on AMP any time soon, that's not to say we definitely won't in the future though. I am super into this clean up project though, so if you're on a mission to have single formats with multiple styles then might be a good one to do. But def don't prioritise it over anything important!

JonNorman commented 7 years ago

Great - thanks Rob. I might just do it as part of my style-sync work. I want to release this tool when everything is nice and consistent and ordered such that we can use any discrepancies as warnings to stop pushing up changes etc.