guardian / content-api-scala-client

A Scala client library for the Guardian's Content API
Apache License 2.0
40 stars 16 forks source link

Proof of concept to release snapshots to sonatype #373

Closed georgeblahblah closed 1 year ago

georgeblahblah commented 1 year ago

Co-authored-by: David Lawes david.lawes@guardian.co.uk

What does this change?

This PR adds a proof of concept for releasing snapshots to sonatype via github actions. This PR makes a couple of changes:

How was this tested?

During development the github workflow was triggered on push events. For the final configuration of the work flow we can see the action was successfully completed:

What next?

After this change is deployed snapshot releases could be made via the github UI by creating a new prerelease. Creating the new prerelease should trigger the workflow (including parsing the version correctly from the release name). This last part of the flow hasn't been tested yet (it can't be until this change has been merged?). After this change has been merged we'd want to:

If we're happy with the prerelease proof of concept we could then:

DavidLawes commented 1 year ago

@rowannekabalan @fredex42 The proof of concept successfully published snapshot releases to sonatype, so I think this might be ready for a review! I'd hope that all changes here are suitably isolated from the current release process (aside from the version bump of plugin sbt-pgp). Let me know your thoughts, happy to chat if that's better!