search

guardian / content-api-scala-client

A Scala client library for the Guardian's Content API
Apache License 2.0
40 stars 16 forks source link

To apply latest version of capiModelsVersion. #390

Closed Divs-B closed 1 year ago

Divs-B commented 1 year ago

What does this change?

This is to update content-api-scala-client to avoid error between latest and old version of content-api-models in the repos (example apple-news) that are using both libraries.

Related to the work of Scala Steward integration in apple-news code. We are encountering error NoSuchMethodError at the moment , details are in ongoing PR https://github.com/guardian/apple-news/pull/249, which is happening after upgrading latest versions of both content-scala-client and content-api-models. This suggests that scala-client is not updated with latest models hence applying the change to release updated version of scala-client. (Guided by Roberto Tyley)

How to test

To test in AN code of we able to resolve the error.

How can we measure success?

Error should be resolved and tests should pass in apple-news code on using latest versions of the api's.

Divs-B commented 1 year ago

Tested the changes locally (thanks for help for how to do by @JustinPinner and @fredex42) First did published locally on scala-client and then tested the created SNAPSHOT version in Apple-news code with changes in build.sbt as val CapiClientVersion = "19.3.2-SNAPSHOT" val CapiModelsVersion = "17.6.3" The tests in apple-news are passing (which was erroring before for NoSuchMethodError as mentioned in PR description).