Various CI fixes, including avoiding `push` as a CI trigger - Githubissues

guardian / content-api-scala-client

A Scala client library for the Guardian's Content API

Apache License 2.0

40 stars 16 forks source link

Various CI fixes, including avoiding `push` as a CI trigger #417

Closed Divs-B closed 6 months ago

Divs-B commented 6 months ago

What does this change?

Co-authored: @rtyley

We are making various CI fixes including using pull request trigger(https://github.com/guardian/content-api-scala-client/pull/417/commits/0e4149eccbb397b4a430d10da9dc31bc8be89315) because push event is very bad choice of trigger for CI on github PRs. Example: https://github.com/guardian/mobile-apps-api/pull/2760

We also updating Test results to get accumulated in test-results folder.

How to test

Raise this as PR (not Draft) and observe CI tests.

How can we measure success?

CI tests should pass on PR

github-actions[bot] commented 6 months ago

Test Results

0 tests ±0 0 :white_check_mark: ±0 0s :stopwatch: ±0s 0 suites ±0 0 :zzz: ±0 0 files ±0 0 :x: ±0

Results for commit 0e4149ec. ± Comparison against base commit 2a092473.

:recycle: This comment has been updated with latest results.