search

guardian / crossword-uploader

Repository for the AWS lambda functions used to upload crosswords
0 stars 0 forks source link

Archive files after upload #10

Closed philmcmahon closed 8 years ago

philmcmahon commented 8 years ago

After a PDF/XML file has been successfully sent to the microapp/composer, copy all versions of it to the crossword-processed-files bucket, then delete it from the crossword-files-for-processing bucket

This should keep the 'files for processing' bucket clean and reduce the chances of something being republished on the wrong day.

shaundillon commented 8 years ago

Looks good to me :+1:

LATaylor-guardian commented 8 years ago

:-1: The sentiment here is correct, but this should only be done when the Lambda is running in PROD. If this was to happen in CODE and the lambda ran before the PROD one this would mean the crosswords would not be uploaded in PROD given they are using a shared bucket at current.

LATaylor-guardian commented 8 years ago

Two ways to fix this:

philmcmahon commented 8 years ago

Thanks Luke! I did it the dirty way...

LATaylor-guardian commented 8 years ago

Lovely job :+1: