search

guardian / csnx

Monorepo for Guardian UIs
https://guardian.github.io/csnx
Apache License 2.0
35 stars 2 forks source link

Set `moduleResolution` to `bundler` in `@guardian/tsconfig` #1501

Closed sndrs closed 1 month ago

sndrs commented 1 month ago

What are you changing?

Setting moduleResolution to bundler in @guardian/tsconfig.

Why?

It enables support for exports in TypeScript while not requiring strict import names (using extensions) i.e. it mimics how bundlers approach imports from local and installed modules.

See https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-beta/#moduleresolution-bundler for more info.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 928a156bf51476bd39884b567da43f9373ea899a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

[!TIP] Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.