search

guardian / csnx

Monorepo for Guardian UIs
https://guardian.github.io/csnx
Apache License 2.0
35 stars 2 forks source link

Add AB test to use `propertyId` in CMP sourcepoint config #1507

Closed Jakeii closed 3 weeks ago

Jakeii commented 1 month ago

What are you changing?

Testing the suggested change from sourcepoint documentation, to use propertyId rather than propertyHref

Most of the world uses a single id, but Australia has their own for some reason.

Why?

When using propertyHref sourcepoint uses an extra network request to determine consent, currently there's 2-3 requests depending on if there are any changes on sourcepoint's side i.e. to the vendorlist. After this change it will be reduced to 1-2.

This should speed up getting consent by 50-33% as it appears to be mostly network bound, and therefore anything else that waits for consent, e.g. advertising.

Before:

Screenshot 2024-05-23 at 13 30 02

After:

Screenshot 2024-05-23 at 13 29 33

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: d422d4f5fa199ee053d685f418386a033e993609

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

[!TIP] Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.