guardian / csnx

Monorepo for Guardian UIs
https://guardian.github.io/csnx
Apache License 2.0
35 stars 3 forks source link

Update typescript setup #1542

Closed sndrs closed 3 months ago

sndrs commented 3 months ago

What are you changing?

Two fixes also need new releases:

Why?

The recent move to using esbuild in rollup (#1385) means that types are not checked as part of the build process.

Even when they were, files which were included in TS projects but were not included in builds (e.g. configs, stories etc) were never checked.

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: ed9b893c8d4f6b1f9b203b52092d9c582353c64a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 months ago

[!TIP] Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.