search

guardian / csnx

Monorepo for Guardian UIs
https://guardian.github.io/csnx
Apache License 2.0
34 stars 2 forks source link

Remove Google Analytics from vendor list in cmp #1548

Closed Jakeii closed 2 weeks ago

Jakeii commented 2 weeks ago

What are you changing?

Remove Google Analytics from the vendor list

Why?

We've removed it from our codebase in https://github.com/guardian/commercial/pull/1393, https://github.com/guardian/dotcom-rendering/pull/11470 and https://github.com/guardian/frontend/pull/27188

And presumably sourcepoint as, vendors.test.ts is failing in my PR #1507

The unit test is not deterministic, checking the vendorlist matches sourcepoint should probably be done in e2e tests not unit tests.

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 0ca31823b903f98cd1cb803dd059f0b66ac71e43

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 weeks ago

[!TIP] Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

sndrs commented 2 weeks ago

@guardian/transparency-consent is this why the libs unit tests are failing?