search

guardian / csnx

Monorepo for Guardian UIs
https://guardian.github.io/csnx
Apache License 2.0
35 stars 2 forks source link

Update Source icon set #1562

Closed jamesmockett closed 2 months ago

jamesmockett commented 3 months ago

What are you changing?

Renamed icons

The following icons have been renamed:

Old name New name
SvgBookMark SvgBookmarkFilled
SvgBookMarkCross SvgBookmarkCross
SvgCrossRound SvgCrossRoundFilled
SvgHouse SvgHomeHouseFilled
SvgPersonRound SvgPersonRoundFilled
SvgShare SvgShareWeb

Deprecated icons

The following deprecated aliases have been removed:

Removed Aliased to
SvgOfflineCloud SvgCrossedOutCloud
SvgAlert SvgExclamation
SvgMessenger SvgFacebookMessenger
SvgInfo SvgInfoRound
SvgPlay SvgMediaControlsPlay
SvgPayPal SvgPayPalBrand

eg. if you are importing SvgOfflineCloud this is aliased to SvgCrossedOutCloud. The alias has now been removed so you should import SvgCrossedOutCloud directly.

The following icons have also been deprecated and will be removed in a future release:

❌ Don't use ✅ Use instead
SvgAlertTriangle SvgAlertRound
SvgFilter SvgFilterOutlinedWeb
SvgShareCallout SvgShareWeb

Why?

Images

All icons

Screenshot 2024-06-19 at 15 00 06

Icon gallery

Screenshot 2024-07-01 at 17 55 35
changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 7b159ce4cfb279c24c208eb2e5bf70b83cb00ef2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 months ago

[!TIP] Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

github-actions[bot] commented 3 months ago

[!NOTE] The following canaries were published to NPM:

🐥

github-actions[bot] commented 3 months ago

[!NOTE] The following canaries were published to NPM:

🐥

jamesmockett commented 2 months ago

i think will need changesets?

Definitely. I thought I'd added one, but seems not 😞 (Or somehow didn't commit it.) Will add now…

jamesmockett commented 2 months ago

Usage of the renamed icons across projects looks like this:

Icon Instances
SvgBookMark 0
SvgBookMarkCross 0
SvgCrossRound 9
SvgHouse 0
SvgPersonRound 0
SvgShare 3

(Note: this ignores usage of the old @guardian/src-icons package and archived repos.)

Usage of the previously deprecated and now removed icons is as follows:

Icon Instances
SvgOfflineCloud 1
SvgAlert 0
SvgMessenger 1
SvgInfo 5
SvgPlay 0
SvgPayPal 1