guardian / csnx

Monorepo for Guardian UIs
https://guardian.github.io/csnx
Apache License 2.0
35 stars 2 forks source link

Add web vital attribution data #1584

Closed abeddow91 closed 3 months ago

abeddow91 commented 3 months ago

What are you changing?

Updates web-vitals to

  1. Send attribution data with CLS, LCP and INP
  2. A new endpoint. The data will now go to the events collector. The events collector does not have separate endpoints for CODE and PROD environments. Instead, this stage is determined by the isDev parameter and added to the payload to allow us to separate the dataset by stage in big query.

Why?

Additional attribution data will help with diagnosing web vital issues on DCR. As well as this, the events collector provides a more agnostic schema with a focus on anonymity of data and is a more fitting pipeline for this dataset.

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 4de52e7ab76560877f00665788cb61d6efb8f890

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 months ago

[!TIP] Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

github-actions[bot] commented 3 months ago

[!NOTE] The following canaries were published to NPM:

🐥

github-actions[bot] commented 3 months ago

[!NOTE] The following canaries were published to NPM:

🐥

github-actions[bot] commented 3 months ago

[!NOTE] The following canaries were published to NPM:

🐥

github-actions[bot] commented 3 months ago

[!NOTE] The following canaries were published to NPM:

🐥

sndrs commented 3 months ago

as this is a major, do you want to incorporate #1581?

github-actions[bot] commented 3 months ago

[!NOTE] The following canaries were published to NPM:

🐥

abeddow91 commented 3 months ago

as this is a major, do you want to incorporate #1581?

I think this seems like a good idea, I'll take a look at bumping this package.

github-actions[bot] commented 3 months ago

[!NOTE] The following canaries were published to NPM:

🐥

github-actions[bot] commented 3 months ago

[!NOTE] The following canaries were published to NPM:

🐥

github-actions[bot] commented 3 months ago

[!NOTE] The following canaries were published to NPM:

🐥

github-actions[bot] commented 3 months ago

[!NOTE] The following canaries were published to NPM:

🐥

github-actions[bot] commented 3 months ago

[!NOTE] The following canaries were published to NPM:

🐥

github-actions[bot] commented 3 months ago

[!NOTE] The following canaries were published to NPM:

🐥

github-actions[bot] commented 3 months ago

[!NOTE] The following canaries were published to NPM:

🐥

github-actions[bot] commented 3 months ago

[!NOTE] The following canaries were published to NPM:

🐥