guardian / developers-site

https://developers.theguardian.com/
7 stars 4 forks source link

jspm build #28

Open guybedford opened 10 years ago

guybedford commented 10 years ago

I just had a quick look at this and it is looking awesome! It's really great to see the ideas picked up so well and as I hoped.

There is one small change that would make a big difference to the performance, and that is to build out the ES6 modules into ES5 for production.

The jspm build operation is designed to do this for the application code, converting an app directory into an app-build directory which can behave the same in production, just without needing Traceur in the page.

It should work relatively easily, but just let me know if you need a hand with this at all.

theefer commented 10 years ago

Thanks for taking a look at our new site!

You're right about pre-transpiling the code, it's definitely an optimisation we were considering, but we were keen to get the site working and released, and to keep iterating on it to iron out such improvements.

Thanks for all the fantastic work on SystemJS and jspm, we're starting to use them at the Guardian both for hacks and real products and we're keen to help out improving them where possible!

guybedford commented 10 years ago

It should be as simple as that one line command for the ES6 compilation to work, so just let me know if you have any problems.

It's great to hear you guys are using it, and as you run into issues I'm happy to help or point you in the direction of a fix, as we've been doing. Contribution that way works great. If you do need to discuss things more in-depth feel free to ping me any time.