guardian / dotcom-rendering

The Guardian web rendering service (aka DCR/DCAR)
https://www.theguardian.com
Apache License 2.0
255 stars 30 forks source link

[Bug]: `@guardian/commercial` peer dependency mismatch #10204

Closed mxdvl closed 9 months ago

mxdvl commented 9 months ago

What happened?

There are a number of peer dependency mismatches in DCR for @guardian/commercial. Excerpt from pnpm i --resolution-only:

# …
├─┬ @guardian/commercial 11.32.1
│ ├── ✕ unmet peer @guardian/libs@^15.6.4: found 16.0.0
│ ├── ✕ unmet peer @guardian/source-foundations@^13.0.0: found 14.1.2
│ ├── ✕ unmet peer @guardian/ab-core@^5.0.0: found 7.0.1
│ ├── ✕ unmet peer @guardian/core-web-vitals@^5.1.0: found 6.0.0
│ └─┬ prebid.js 8.24.0
│   └─┬ @guardian/libs 15.7.1
│     └── ✕ unmet peer typescript@~5.1.3: found 5.3.3
# …

[!TIP] You can check this yourself by running pnpm install --resolution-only

@guardian/commercial-dev please could you update this package to use versions that are compatible with this repo?

What is the impact?

This will soon become a blocker as we want to enforce met peer dependencies in this repo

Jakeii commented 9 months ago

Noted, will get this sorted out!

i-hardy commented 9 months ago

We'll be tackling the prebid dependency separately; the others should be fixed by https://github.com/guardian/frontend/pull/26819 and https://github.com/guardian/dotcom-rendering/pull/10243

cemms1 commented 9 months ago

Thanks @i-hardy, that's great! ✨ Will leave this ticket open until the prebid dep is sorted