guardian / dotcom-rendering

The Guardian web rendering service (aka DCR/DCAR)
https://www.theguardian.com
Apache License 2.0
253 stars 29 forks source link

Apps Notifications from `left-col` breakpoint #12231

Open domlander opened 1 month ago

domlander commented 1 month ago

Apps articles and liveblogs only show notifications when there is no left column. Once there is a left column, the metadata is moved out to the left and the notifications button disappears.

We should include the notifications button in the left column. This needs design input as the left column can be small and there is not always enough space for the icon and the text to appear side-by-side.

Small screens Large screens
article article-desktop article-leftCol
liveblog liveblog-tablet liveblog-desktop
domlander commented 1 month ago

The icon and text "Notifications off" doesn't fit in the left column at the left-col breakpoint as it stands. I spoke to Harry F and he suggests removing the right-margin from this element at the left-col breakpoint only so that it fits:

Image

domlander commented 1 month ago

Unassigning myself as anyone can pick this up