guardian / dotcom-rendering

The Guardian web rendering service (aka DCR/DCAR)
https://www.theguardian.com
Apache License 2.0
255 stars 30 forks source link

Improve sharing experience on desktop liveblogs #12411

Open domlander opened 1 month ago

domlander commented 1 month ago

The "Share" button on liveblog blocks works really well on mobile phones. However, it is not very useful on desktop (OS and browser dependent), where a user is sometimes unable to simply copy the link. MacOS support has been added for this feature as of version 128 of Chrome, so it is now starting to affect more users and staff.

Image

Suggested improvements from Gabriel, Jonathon & CP:

Thread: https://groups.google.com/a/guardian.co.uk/g/dotcom.platform/c/8hkcV3k6Flw

*We currently have fallback functionality which will show a Copy Link button instead of a Share button if the Web Share API is not supported. See ShareButton.importable for details.

domlander commented 1 month ago

Design (Rich & Harry) feedback:

SiAdcock commented 1 month ago

Do the same for articles, which are also affected

Do we need a "copy link" button on articles? The reader would normally copy the URL from the browser's address bar, making this method slightly redundant. What do you think @richcousins @HarryFischer

domlander commented 1 month ago

Do we need a "copy link" button on articles? The reader would normally copy the URL from the browser's address bar, making this method slightly redundant. What do you think @richcousins @HarryFischer

The fallback functionality still shows a "Share" button initially, but when it is clicked, the text content changes to "Link copied".

Apologies for the confusion.

richcousins commented 1 month ago

Do we need a "copy link" button on articles? The reader would normally copy the URL from the browser's address bar, making this method slightly redundant. What do you think @richcousins @HarryFischer

The fallback functionality still shows a "Share" button initially, but when it is clicked, the text content changes to "Link copied".

Apologies for the confusion.

We're happy to drop back all desktop to this functionality – thanks!

SiAdcock commented 1 month ago

The confusion was all mine 😄 Thanks everyone 🙏