guardian / dotcom-rendering

The Guardian web rendering service (aka DCR/DCAR)
https://www.theguardian.com
Apache License 2.0
255 stars 30 forks source link

Fronts Ophan tag parity (`data-link-name`) #4692

Closed mxdvl closed 1 year ago

mxdvl commented 2 years ago

Remaining Front components mismatches

Comparing data-link-name on the international Front between Frontend & DCR.

Missing from DCR (26 / 601)

Tag mismatch (111 / 601)


Identical match (464 / 601)

mxdvl commented 2 years ago

See also #4698

VDuczekW commented 1 year ago

review on and after launch

rhiannareechaye commented 1 year ago

We need to implement this tracking before launch - we need to go through all the components, figure out if they have a datalink name and if not we need to add it as it should be the same as Frontend since these labels drive the GA data - this ticket makes it clear of all the stuff that's missing

rhiannareechaye commented 1 year ago

#4698

ioannakok commented 1 year ago

Tracking progress of current ticket & #4698 here: https://docs.google.com/spreadsheets/d/1mrlXCd9Vd237Txw03v436eSoIuSrTvn6CzLpWsbmyfw/edit#gid=0

ioannakok commented 1 year ago

Sub-tasks:

rhiannareechaye commented 1 year ago

@ioannakok and @mxdvl hey both :) What do we need to do to close this issue?

rhiannareechaye commented 1 year ago

I understand now this is an automated ticket - seems like there a few items that are unticked. I don't think this is a blocker for us but @jamesgorrie is going to take a look too

shesah commented 1 year ago

Done!