guardian / dotcom-rendering

The Guardian web rendering service (aka DCR/DCAR)
https://www.theguardian.com
Apache License 2.0
255 stars 30 forks source link

Liveblogs in DCR: What's left? #4808

Closed OllysCoding closed 2 years ago

OllysCoding commented 2 years ago

This issue is designed to track the remaining process in getting DCR to support liveblogs

What's left?

We don't yet support every form of liveblogs in DCR, what we do support is served to 100% of our audience.

Themes

Sport types

Testing & Comparisons

Rugby

Rugby Needs to be discussed with CP, we do not currently pay PA for rugby data, but Frontend does have the API & components to support it if we did. An ideal resolution would be to agree with CP & the sports desk on advanced notice if rugby scoreboards were expected to be supported again

Update: CP & Sports desk signed off on moving to DCR, with support for rugby to be added in the future

Opinion

Frontend DCR
Example Example
opinionFrontend1 opinionDCR1
opinionFrontend2 opinionDCR2

Notes:

  1. The slight colour and layout differences are expected, the colour contrast is increased (for accessibility of course!) and the column width were intended for DCR.
  2. There appears to be a problem with comment elements, while the design is generally different in DCR, it appears not to account for when I comment has a quote/reference in it, with no visual differences between the quote & the comment itself.

Special Report

TODO

https://www.theguardian.com/news/live/2021/oct/05/pandora-papers-expose-eu-plans-on-tax-havens-as-absurd-meps-claim-live?dcr&live

https://www.theguardian.com/news/live/2021/oct/04/pandora-papers-live-sunak-says-hmrc-will-review-leaked-documents?dcr&live

Labs

After running a capi query for labs liveblogs, we can see that there are no labs liveblogs.

Using storybook we can see what a labs liveblog might look like:

image

We should consider updating the colours of the nav to provide a more complete experience

OllysCoding commented 2 years ago

Will be closed by https://github.com/guardian/frontend/pull/25017