guardian / dotcom-rendering

The Guardian web rendering service (aka DCR/DCAR)
https://www.theguardian.com
Apache License 2.0
253 stars 29 forks source link

Inline images with weighting `immersive` obscure content/ads in the right column #5108

Open oliverlloyd opened 2 years ago

oliverlloyd commented 2 years ago

We see images in the body of articles obscure content in the right column in some situations

1) Where the article is rendered in a browser using an ad-blocker. In this scenario the Most Viewed list is stuck to the top of the page 2) If ads are placed in the right column by space-finder then this is not aware that the image is stretching into the right column

Screenshot 2022-06-01 at 11 15 07

Should we add a flag / prop that indicates that at least one image in the article has the immersive weighting and pass that through to allow different decisions to be made? E.g.: We could choose to not stick Most Viewed in this situation.

@guardian/commercial-dev ?

jlieb10 commented 2 years ago

Waiting to hear from @guardian/commercial-dev

rhiannareechaye commented 1 year ago

We are deprioritising this ticket by 'closing a not planned' - this won't delete the ticket and it will be searchable if the issue crops up again. Unfortunately we have over 130 health tickets to address in the web team. With so many tickets we are potentially missing things that are high-impact so we're reorganising the board - if we can get through all our high-impact tickets we can re-open these lower impact ones.

cemms1 commented 1 year ago

This issue has been raised in an email today (17/07/2023)

Would you be able to look at this piece for us: https://www.theguardian.com/football/2023/jul/16/womens-world-cup-2023-stadium-guides-stadium-australia-accor-sydney-football-allianz-melbourne-rectangular-aami-brisbane-suncorp-perth-hbf-hindmarsh-adelaide-eden-park-auckland-dunedin-forsyth-barr-wellington-regional-sky-waikato-fmg

When set to the 'photo essay' display hint, the main image covers date/time, sponsorship and bylines (half cut off). For now, I have switched it to immersive which has helped slightly, but the date has disappeared on desktop and the ad is underneath. The piece is looking ok on app and mobile, however we also noticed the thumbnail maps do not show up.

Screenshots: Desktop Mobile
desktop1 desktop2 mobile
paperboyo commented 1 year ago

A Sense of History: this one (and related) has quite a beard: https://github.com/guardian/frontend/issues/9089.

alinaboghiu commented 7 months ago

Also covers the most viewed container as explained here: https://github.com/guardian/dotcom-rendering/issues/9545