search

guardian / dotcom-rendering

The Guardian web rendering service (aka DCR/DCAR)
https://www.theguardian.com
Apache License 2.0
255 stars 30 forks source link

MAPI should set a minimum supported Bridget version for articles with a promoted newsletter #6402

Open georgeblahblah opened 2 years ago

georgeblahblah commented 2 years ago

Newsletter sign ups utilise functionality only available in Bridget >= 1.13.0. We should enable Apps Rendering support for articles which have a newsletter signup in MAPI specifying a minimum Bridget version of 1.13.0.

https://github.com/guardian/mobile-apps-api/pull/2088 is a related PR making a similar change.

georgeblahblah commented 1 year ago

@dblatcher I realise now we never did this work. Newsletter signups won't work on older versions of the app with Bridget versions < 1.13.0

dblatcher commented 1 year ago

@dblatcher I realise now we never did this work. Newsletter signups won't work on older versions of the app with Bridget versions < 1.13.0

@georgeblahblah thanks for flagging - there were some user issues flagged, I think. Do you need any help getting this done?

georgeblahblah commented 1 year ago

@dblatcher I think we should be able to do this within WebX! The implication is that articles with a newsletter signup will be rendered with the legacy templates, if the app is below Bridget 1.13.0

VDuczekW commented 1 year ago

will we force update when meetering is introduced?

rhiannareechaye commented 1 year ago

Since we have over 130 health tickets in our health board, we have closed a number of tickets. This ticket has not been prioritised, but we don't want to close it. If we get through all the tickets under our 'Small(ish), high impact, tickets' by the end of the Q, we will revisit this ticket. For now we unfortunately have to leave it in the limbo that is 'Triage revisit'