Open bryophyta opened 1 year ago
Do we need to migrate this over to DCR as part of the 1% test?
I would say no given the usage of this component.
Is the
allPath
functionality in Frontend currently working as intended?
It's a good question - but we do have an expected way for it to work, which we can port over to TS pretty easily with tests which would put us in a much better position to work with UX.
do we know how to clarify its role in SEO?
It allows search engines to reach fewer deadends and make more connections between our content. So it should boost juice to the pages linked. The whole site is like this so we should try to maintain this linkability.
we do have an expected way for it to work, which we can port over to TS pretty easily with tests which would put us in a much better position to work with UX.
This makes a lot of sense!
Do we need to migrate this over to DCR as part of the 1% test?
I would say no given the usage of this component.
That seems reasonable to me; I'll remove the 1% milestone and make sure it's in the 'next steps' list for Fronts migration.
I think the conclusion here is:
If the front is overriding a tag page we link through to /{tag}/all
. This includes editionalisation.
e.g. /{?edition}/commentisfree
-> /commentisfree/all
If the front is the edition front, it goes through to the relevant tag:
/uk
-> /uk-news/all
/us
-> /us-news/all
/au
-> /australia-news/all
/international
-> /world/all
Hi all - I think this has been resolved so wondering if I can close this ticket 'as not planned' @jamesgorrie @bryophyta
Hi all - I think this has been resolved so wondering if I can close this ticket 'as not planned' @jamesgorrie @bryophyta
As far as I can tell it looks like #7947 fixes a separate issue, which just concerns trending topics links. When we migrated the topics links over to DCR we bracketed this 'all stories' link as something to migrate separately. @DanielCliftonGuardian may know more than me though about what's happened since I was on the team?
fwiw my 2 cents is that it would be worth trying to gauge how important this 'all stories' link is from an SEO perspective, because it wasn't clear to me that it pays its way otherwise, as recreating in DCR is likely to add non-trivial extra complexity. (I tried to outline this reasoning in the issue description, but happy to elaborate if it'd be useful.)
Hi all - I think this has been resolved so wondering if I can close this ticket 'as not planned' @jamesgorrie @bryophyta
As far as I can tell it looks like #7947 fixes a separate issue, which just concerns trending topics links. When we migrated the topics links over to DCR we bracketed this 'all stories' link as something to migrate separately. @DanielCliftonGuardian may know more than me though about what's happened since I was on the team?
fwiw my 2 cents is that it would be worth trying to gauge how important this 'all stories' link is from an SEO perspective, because it wasn't clear to me that it pays its way otherwise, as recreating in DCR is likely to add non-trivial extra complexity. (I tried to outline this reasoning in the issue description, but happy to elaborate if it'd be useful.)
Thanks @bryophyta, this still hasn't been implemented and I am not aware of any decision or analysis that has taken place that suggests we remove this feature so we should still look at how we wish to prioritise the issue.
Personally, and given excellent description and thoughts here, I would implement it everywhere, even more so because its functionality (the only way to get to an underlying tag page of an editionalised front) is only available via manually (!) curated treat which is a) desktop-only (sic!) and b) may go away with Fairground…
The 'topics' bar at the bottom of fronts pages is made up of two parts.
All today's stories
link at the beginning of the list (highlighted below).Status quo for "All today's stories"
Generally speaking, for a tag or section page the
allPath
link should link to the non-editionalised front which displays all stories in that tag or section, e.g.All today's stories
on theuk/lifeandstyle
front will link tolifeandstyle/all
.The
allPage
URL is not defined in the CAPI or facia-press models, so Frontend uses a heuristic to find the relevant path.Current heuristic for generating an 'allPath'
Roughly: if the page id matches the section id of at least one tag belonging to a curated story in that page, then remove the edition (if any) from the page id and add '/all' to the end of it.
This won't always yield a path. If it doesn't, then Frontend tries to find a path ending in '/all' in one of the treats on the front. (This is how the
allPath
for the/uk
front gets determined.)Issues/Questions
allPath
functionality in Frontend currently working as intended? (the/uk
front'sAll today's stories
link goes totone/letters/all
-- drawn from a treat on the front -- which is unlikely to be what users would expect).