guardian / dotcom-rendering

The Guardian web rendering service (aka DCR/DCAR)
https://www.theguardian.com
Apache License 2.0
253 stars 29 forks source link

Take into account `isPaidContent` in merchandising high logic #7619

Closed ioannakok closed 1 year ago

ioannakok commented 1 year ago

Once DCR supports isPaidContent we need to make sure we're taking this into account in the logic that decides the position of merchandising high. See frontend logic.

rhiannareechaye commented 1 year ago

There are two merchandising ad slots (merchandising high is the top one). We can't have 'paid content' and then merchandising content together so we need some logic which moves this slot when it goes next to a paid content container. This would be either small or medium - a lot of the logic is already there

chrislomaxjones commented 1 year ago

As far as I can tell, the rules laid out in @rhiannareechaye's comment above isn't implemented on Frontend. I captured the image below from https://www.theguardian.com/education?dcr=false (I think the Frontend has since been changed in the tools, so no longer has the labs container), which shows a labs container next to the merchandising high slot.

Image

I checked with @Amouzle and I think from a Commercial perspective we're happy to keep parity with Frontend on this one, rather than try and build an enhancement.

In terms of @ioannakok's comment, I think the isPaidContent flag is now being respected by DCR, looking here at least.

Assuming no objection from WebEx, we can close this ticket as not planned?

ashishpuliyel commented 1 year ago

@chrislomaxjones Agreed it should be closed. If someone wants the feature they can raise a request with comm-dev.