guardian / dotcom-rendering

The Guardian web rendering service (aka DCR/DCAR)
https://www.theguardian.com
Apache License 2.0
253 stars 29 forks source link

Ad parity #8082

Closed arelra closed 1 year ago

arelra commented 1 year ago

We should track ad parity for DCR vs Frontend network fronts.

D&I are working on creating an ad parity tracker.

We should agree the roll out % and schedule with D&I and Commercial dev

### Tasks
- [x] D&I to refresh ad parity tracker
- [x] mobile-6 ad slot is missing on the international front
- [x] merchandising-high and mobile1 slots differ in position compared to Frontend
- [x] mobile and desktop slots should be removed from the dom when not at that breakpoint
arelra commented 1 year ago

mobile6-inline is fixed by: https://github.com/guardian/dotcom-rendering/pull/8112

arelra commented 1 year ago

slots positioning parity fixed by: https://github.com/guardian/dotcom-rendering/pull/8126

rhiannareechaye commented 1 year ago

https://docs.google.com/spreadsheets/d/1SKBBciRIWuxfXmTjGx0_CwbQktU5C2BP8h-hzHgmFIQ/edit#gid=1391693339

rhiannareechaye commented 1 year ago

Can we take a look at this too please:

one quick one - I noticed the cycling had an ad slot missing on DCR on first slice of first container https://www.theguardian.com/sport/cycling?dcr=false vs https://www.theguardian.com/sport/cycling?dcr=true

arelra commented 1 year ago

cycling had an ad slot missing on DCR

This is a tagged front for which ad slot support has just been merged with: https://github.com/guardian/dotcom-rendering/pull/8056

We should be seeing ad slots on tagged fronts appear soon

arelra commented 1 year ago

Mobile and desktop slot hiding closed by: https://github.com/guardian/dotcom-rendering/pull/8263