search

guardian / dotcom-rendering

The Guardian web rendering service (aka DCR/DCAR)
https://www.theguardian.com
Apache License 2.0
253 stars 29 forks source link

Sublink hover state #8102

Open HarryFischer opened 1 year ago

HarryFischer commented 1 year ago

2 things: Firstly, the rule seems to be a little thick and cuts the ascenders on the row below. Second, as you scroll down the DCR front on a phone you keep triggering the hover states which are a bit distracting. Maybe we only introduce hover states after tablet breakpoint?

HarryFischer commented 1 year ago

Image

paperboyo commented 1 year ago

I think underlines are good now? Is the issue with involuntary navigation still occurring, @HarryFischer?

HarryFischer commented 1 year ago

@paperboyo It still seems off to me. It triggers as i scroll down the page and also cuts the ascenders hover

paperboyo commented 1 year ago

Thx! You are right, sorry.

This is Firefox:

image

This is Chrome:

image

(both on OS13)