search

guardian / dotcom-rendering

The Guardian web rendering service (aka DCR/DCAR)
https://www.theguardian.com
Apache License 2.0
253 stars 29 forks source link

Address flakey Chromatic snapshots in discussion rendering #8183

Closed cemms1 closed 8 months ago

cemms1 commented 1 year ago

The Story App: Logged in but closed for comments results in flakey visual diffs on different PRs.

E.g. https://www.chromatic.com/pullrequest?appId=63e251470cfbe61776b0ef19&number=7902&activeElementId=comparison-test-key-649d54fd9d7916f83e0a48f0-1200&view=changes

It would be good to fix this so that we don't have unexplained, unexpected diffs happening on unrelated PRs

abeddow91 commented 1 year ago

https://github.com/guardian/dotcom-rendering/pull/8355 also seen here... eg https://www.chromatic.com/test?appId=63e251470cfbe61776b0ef19&id=64bf9c596f7a5489f2ce7406

cemms1 commented 8 months ago

Haven't seen this happen in a while, which may be because of recent work on the Discussion components. Closing