guardian / dotcom-rendering

The Guardian web rendering service (aka DCR/DCAR)
https://www.theguardian.com
Apache License 2.0
253 stars 29 forks source link

Remove palette styles container from fronts #8407

Open cemms1 opened 1 year ago

cemms1 commented 1 year ago

There has been some discussion about the old palette styles container, added in the fronts tool to provide additional CSS for thrashers on a page. DCR rendered fronts do not need this container so once we have fully switched rendering over to DCR, with no need to revert back to frontend for anything, these can be removed.

Relevant conversations:

In order to do this, we would need to ask CP to remove these containers from the fronts and reflect this in the code so that we no longer take these containers into account in our rendering flow.

There are potentially some applications at the time of writing that would fail due to this change so this ticket is here to remind us to chat about it in the future when we are more confident that this wont negatively affect rendering.

Prevent Fronts Falling Back To Frontend

To prevent fronts ever falling back to frontend, we need to a) migrate all frontend fronts features to DCAR, or b) deprecate any frontend features that DCAR will not support.

### Tasks
- [ ] Deprecate `json.html` thrashers
alinaboghiu commented 11 months ago

Unfortunately we cannot do this until we've decommissioned frontend fronts. If for any reason a DCR front reverts to frontend styling would be broken without this palette.

alinaboghiu commented 11 months ago

If we do this, we will be able to archive this repo: https://github.com/guardian/interactive-atom-container-colours