search

guardian / dotcom-rendering

The Guardian web rendering service (aka DCR/DCAR)
https://www.theguardian.com
Apache License 2.0
250 stars 28 forks source link

Reinstate Lighthouse CI check #8869

Open DanielCliftonGuardian opened 9 months ago

DanielCliftonGuardian commented 9 months ago

@bryophyta noticed that we have not reinstated this check https://github.com/guardian/dotcom-rendering/pull/7425#issuecomment-1490066486 And noticed an issue when upgrading LHCI https://github.com/guardian/dotcom-rendering/actions/runs/6234411873/job/16921542025 chat message: https://chat.google.com/room/AAAAG9rU0m0/b1KhuZzurK0

cemms1 commented 3 months ago

Had a quick play around with the community Lighthouse action here https://github.com/guardian/dotcom-rendering/actions/runs/8378450478

Looks promising!

EDIT: I think it would be worth considering what we want to use Lighthouse for. It might be that scheduling a Lighthouse CI run once a week to run on the PROD env and then either email the results to the team, or potentially automatically create issues off the back of the results would make more sense than including it as part of the CICD run.