guardian / dotcom-rendering

The Guardian web rendering service (aka DCR/DCAR)
https://www.theguardian.com
Apache License 2.0
255 stars 30 forks source link

Check with design about one off colours in palette #9531

Open sophie-macmillan opened 1 year ago

sophie-macmillan commented 1 year ago

While implementing dark mode, we've been copying across and updating the palette. We've come across some one off colours that we should check. Are these intending, or can we update them to use the standard sourcePalette?

### Tasks
- [ ] [Headline border for liveblogs](https://github.com/guardian/dotcom-rendering/blob/af1661390af82d42da54a67203403d14635046d6/dotcom-rendering/src/palette.ts#L976-L977) `currently rgba(255,255,255, 0.2)`
- [ ] [Headline border for deadblogs](https://github.com/guardian/dotcom-rendering/blob/af1661390af82d42da54a67203403d14635046d6/dotcom-rendering/src/palette.ts#L978-L979) `currently #CDCDCD`
- [ ] [Standfirst border for liveblogs](https://github.com/guardian/dotcom-rendering/blob/af1661390af82d42da54a67203403d14635046d6/dotcom-rendering/src/palette.ts#L1945-L1946) `currently rgba(255,255,255, 0.2)`
- [ ] [Standfirst border for deadblogs](https://github.com/guardian/dotcom-rendering/blob/af1661390af82d42da54a67203403d14635046d6/dotcom-rendering/src/palette.ts#L1947-L1948) `currently #BDBDBD`
HarryFischer commented 1 year ago

Headline border for liveblog: return transparentColour(sourcePalette.neutral[100], 0.2); Headline border for liveblog: neutral.86 (#dcdcdc) Headline border for deadblog: return transparentColour(sourcePalette.neutral[100], 0.2); Standfirst border for deadblog: neutral.86 (#dcdcdc)

georgeblahblah commented 1 year ago

we are moving this to backlog in planning because liveblogs&deadblogs are not prioritised for the first production release

sophie-macmillan commented 11 months ago

@HarryFischer could we also check this one off colour please? #d9edf6. Used for the matchStats background https://github.com/guardian/dotcom-rendering/blob/8b238906d29de60676cfc845857fc31a717f0d48/dotcom-rendering/src/lib/decidePalette.ts#L1159