search

guardian / facia-scala-client

Low level client for the Facia JSON API
Other
2 stars 1 forks source link

Fix link snap branding #191

Closed kelvin-chappell closed 7 years ago

kelvin-chappell commented 7 years ago

So that it no longer makes unnecessary calls to capi.

janua commented 7 years ago

I wonder is it worth adding the same logic that the CAPI client has around containing a query parameter in a URL? Actually, looking at it, URI.getPath is probably stripping out any possible query parameters anyway (Even though they may be removed upstream from facia-tool, not sure.)

👍

kelvin-chappell commented 7 years ago

Yes, this test shows that the query string is stripped out.