search

guardian / facia-scala-client

Low level client for the Facia JSON API
Other
2 stars 1 forks source link

Fixes #218: populates displayName from collectionConfig #219

Closed simone-smith closed 5 years ago

simone-smith commented 5 years ago

@rtyley and I have discussed this with @Reettaphant, and have agreed that we should be checking the collectionConfig first for the displayName and href. It seems that neither of these fields are being written into collection content any more - they are only configured through collection config.

cc @jonathonherbert

Fixes #218

jonathonherbert commented 5 years ago

@rtyley @simone-smith couldn't be happier with this, thanks for investigating -- @Reettaphant thanks for confirming 👍

I wonder how many other orphaned or redundant properties exist on collections; it should be fairly trivial to write a script to check? I'll add a card for health week.

philmcmahon commented 5 years ago

Hope releasing this goes ok. I have done it before on my new laptop, happy to give it a go if you encounter difficulties