search

guardian / facia-scala-client

Low level client for the Facia JSON API
Other
2 stars 1 forks source link

Geotargeting collections: add 'TargetedTerritory' to CollectionConfigJson #223

Closed jonathonherbert closed 5 years ago

jonathonherbert commented 5 years ago

This PR adds an optional 'TargetedTerritory' property to the CollectionConfigJson class, allowing us to specify a targeted territory on a per-Collection basis.

It's needed to support the upcoming work targeting containers to specific geographic regions.

At the moment, we only support a single territory per Collection -- let me know if this should be a List[TargetedTerritory]!

alexduf commented 5 years ago

At the moment, we only support a single territory per Collection -- let me know if this should be a List[TargetedTerritory]

I think it makes sense as a single value. If we were to have one container to span across multiple countries for instance, then we would probably adapt the geolocation in the first place, like how we're grouping eu-27.

jonathonherbert commented 5 years ago

@alexduf brilliant, thanks for the feedback 👍