guardian / facia-scala-client

Low level client for the Facia JSON API
Other
2 stars 1 forks source link

Add blockId to trail meta #234

Closed jonathonherbert closed 4 years ago

jonathonherbert commented 4 years ago

Adds an optional blockId property to our Trail objects.

Required to let facia-tool store block ids for breaking news notifications that refer to liveblogs, allowing notification clients to point the user to a specific block in a liveblog.

ajwl commented 4 years ago

NB: adding AtomId required a few more changes. Are we likely to require some more of these? https://github.com/guardian/facia-scala-client/pull/231/files

jonathonherbert commented 4 years ago

Great question, @ajwl -- going through those files,

I hope that makes sense, and we can always revisit if necessary.

ajwl commented 4 years ago

👍 cool thanks for the update. Will proceed with this